Make module imports public to survive internal imports by default#710
Merged
ktoso merged 1 commit intoswiftlang:mainfrom Apr 17, 2026
Merged
Make module imports public to survive internal imports by default#710ktoso merged 1 commit intoswiftlang:mainfrom
ktoso merged 1 commit intoswiftlang:mainfrom
Conversation
Maybe resolves swiftlang#705 Alternatives would be to keep internal imports but that's an adventure since we need to keep those thunks NOT dead code eliminated... and we cannot use @used until swift 6.3 so this could not be used in previous swift builds...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maybe resolves #705
Alternatives would be to keep internal imports but that's an adventure since we need to keep those thunks NOT dead code eliminated... and we cannot use @used until swift 6.3 so this could not be used in previous swift builds...